Fallback to default AWS credential chain #7952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
The changes LGTM, but I don't know if we want to commit to supporting default credential providers. We are contemplating moving away from the AWS SDK to minimize the dependency requirements. |
dcousens
force-pushed
the
main
branch
3 times, most recently
from
26e4ead to
f2ca4d1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dcousens
changed the title
dcousens
approved these changes
Jul 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the S3 Client credentials to undefined, the AWS SDK will fallback to a default credential chain, attempting to load credentials from the instance profile, .ini file, environment variables etc:
https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/setting-credentials-node.html
This allows users to follow AWS best practices by using temporary credentials:
https://docs.aws.amazon.com/general/latest/gr/aws-access-keys-best-practices.html
To achieve this, I've made the s3Storage.accessKeyId and s3Storage.secretAccessKey configuration items optional.