Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adminMeta argument to getAdminMeta function in custom field types and the associated types for it #7913

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Sep 12, 2022

This pull request removes the parameters for getAdminMeta when writing field types, and the respective types AdminMetaRootVal, ListMetaRootVal and FieldMetaRootVal therein.

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022

🦋 Changeset detected

Latest commit: 4816f26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 43 packages
Name Type
@keystone-6/core Major
@keystone-6/example-assets-local Patch
@keystone-6/example-assets-s3 Patch
@keystone-6/example-auth Patch
@keystone-6/example-app-basic Patch
@keystone-6/example-blog Patch
@keystone-6/example-custom-admin-ui-logo Patch
@keystone-6/example-custom-admin-ui-navigation Patch
@keystone-6/example-custom-admin-ui-pages Patch
@keystone-6/example-custom-field-view Patch
@keystone-6/example-custom-field Patch
@keystone-6/example-with-custom-session-validation Patch
@keystone-6/example-default-values Patch
@keystone-6/example-document-field Patch
@keystone-6/example-ecommerce Patch
@keystone-6/example-embedded-nextjs Patch
@keystone-6/example-extend-graphql-schema-graphql-ts Patch
@keystone-6/example-extend-graphql-schema-nexus Patch
@keystone-6/example-extend-graphql-schema Patch
@keystone-6/example-extend-graphql-subscriptions Patch
@keystone-6/example-feature-boilerplate Patch
@keystone-6/example-graphql-ts-gql Patch
@keystone-6/example-json-field Patch
@keystone-6/example-rest-api Patch
@keystone-6/example-roles Patch
@keystone-6/singleton Patch
@keystone-6/example-task-manager Patch
@keystone-6/example-testing Patch
@keystone-6/example-virtual-field Patch
@keystone-6/example-with-auth Patch
@keystone-6/example-document-field-customisation-keystone-server Patch
@keystone-6/example-e2e-boilerplate-keystone-server Patch
@keystone-6/auth Major
@keystone-6/cloudinary Major
@keystone-6/fields-document Major
@keystone-6/session-store-redis Major
@keystone-6/benchmarks-legacy Patch
@keystone-6/test-projects-basic Patch
@keystone-6/test-projects-crud-notifications Patch
@keystone-6/test-projects-live-reloading Patch
@keystone-6/sandbox Patch
@keystone-6/generate-artifacts-for-projects Patch
@keystone-6/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 2:47AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4816f26:

Sandbox Source
@keystone-6/sandbox Configuration

@emmatown emmatown force-pushed the remove-public-admin-meta branch from c18ee40 to 58c1d4b Compare September 12, 2022 06:57
@vercel vercel bot temporarily deployed to Preview September 12, 2022 07:14 Inactive
@emmatown emmatown marked this pull request as ready for review September 12, 2022 07:20
@emmatown emmatown requested a review from a team September 12, 2022 07:20
@emmatown emmatown enabled auto-merge (squash) September 12, 2022 07:20
@vercel vercel bot temporarily deployed to Preview September 13, 2022 02:40 Inactive
@vercel vercel bot temporarily deployed to Preview September 13, 2022 02:42 Inactive
@dcousens dcousens force-pushed the remove-public-admin-meta branch from 4942ced to 4816f26 Compare September 13, 2022 02:45
@vercel vercel bot temporarily deployed to Preview September 13, 2022 02:47 Inactive
@emmatown emmatown merged commit 267d8c1 into main Sep 13, 2022
@emmatown emmatown deleted the remove-public-admin-meta branch September 13, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants