Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept readonly arrays in public APIs #6790

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Accept readonly arrays in public APIs #6790

merged 2 commits into from
Oct 14, 2021

Conversation

emmatown
Copy link
Member

This is basically just to allow people to write arrays with as const and then pass them to keystone without casting

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2021

🦋 Changeset detected

Latest commit: 9708260

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystone-next/auth Patch
@keystone-next/keystone Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/2nmUfdxRLy1dLcdWV2xwG6ubuAcV
✅ Preview: https://keystone-next-docs-git-accept-readonly-arrays-keystonejs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@JedWatson JedWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stoked for this, thanks @mitchellhamilton

@emmatown emmatown merged commit f683dcf into main Oct 14, 2021
@emmatown emmatown deleted the accept-readonly-arrays branch October 14, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants