Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extensions with numbers (eg mp3, woff2) #6714

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Add support for extensions with numbers (eg mp3, woff2) #6714

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0e8c46
Authorise extensions with numbers (Eg: mp3)
Zlitus Oct 5, 2021
66d04ba
update comment
dcousens Nov 1, 2021
5072628
add changeset
dcousens Nov 1, 2021
e82fc43
Merge branch 'main' into patch-1
dcousens Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-bulldogs-suffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@keystone-next/keystone": patch
---

When generating safe filenames, support extensions with numerical characters
4 changes: 2 additions & 2 deletions packages/keystone/src/lib/context/createFilesContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ const generateSafeFilename = (
//
// This regex lazily matches for any characters that aren't a new line
// it then optionally matches the last instance of a "." symbol
// followed by any alphabetical character before the end of the string
const [, name, ext] = filename.match(/^([^:\n].*?)(\.[A-Za-z]+)?$/) as RegExpMatchArray;
// followed by any alphanumerical character before the end of the string
const [, name, ext] = filename.match(/^([^:\n].*?)(\.[A-Za-z0-9]+)?$/) as RegExpMatchArray;

const id = crypto
.randomBytes(24)
Expand Down