Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace implementation of the lists API #6153

Merged
merged 8 commits into from
Jul 21, 2021

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Jul 21, 2021

This makes the implementation of the lists API be determined by the GraphQL schema rather than hand crafted so it won't need to change for the GraphQL API changes(besides count because it's Special). The external impact of this is that the implicit chunking is no longer a thing which we vaguely discussed removing a while ago.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2021

🦋 Changeset detected

Latest commit: 5578f82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@keystone-next/keystone Major
@keystone-next/example-assets-cloud Patch
@keystone-next/example-assets-local Patch
@keystone-next/example-auth Patch
@keystone-next/examples-app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-embedded-nextjs Patch
keystone-next-app Patch
@keystone-next/example-playground Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-blog Patch
@keystone-next/example-custom-field-view Patch
@keystone-next/example-custom-field Patch
@keystone-next/example-default-values Patch
@keystone-next/example-document-field Patch
@keystone-next/example-extend-graphql-schema Patch
@keystone-next/example-json-field Patch
@keystone-next/example-task-manager Patch
@keystone-next/example-testing Patch
@keystone-next/example-virtual-field Patch
@keystone-next/example-with-auth Patch
@keystone-next/auth Major
@keystone-next/fields-document Patch
@keystone-next/fields Patch
@keystone-next/testing Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/test-projects-basic Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/481hBiobYyu5Q3Ep1ZRhtQ3doh3w
✅ Preview: https://keystone-next-docs-git-remove-server-side-gra-4c1683-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview July 21, 2021 05:21 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2021 05:25 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2021 05:37 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2021 05:45 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2021 05:50 Inactive
@emmatown emmatown marked this pull request as ready for review July 21, 2021 06:01
@emmatown emmatown requested a review from a team July 21, 2021 06:01
@vercel vercel bot temporarily deployed to Preview July 21, 2021 06:02 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2021 06:06 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmatown emmatown enabled auto-merge (squash) July 21, 2021 06:23
@emmatown emmatown merged commit 7716315 into master Jul 21, 2021
@emmatown emmatown deleted the remove-server-side-graphql-client branch July 21, 2021 06:24
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants