-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add db.provider to replace db.adapter #5368
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/5hYigkwMaU8xts8Z6CKMSSX34Nt7 |
🦋 Changeset detectedLatest commit: 64ed79d The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
38e3dd2
to
e7a289a
Compare
adapter: 'prisma_postgresql'; | ||
provider?: undefined; | ||
} | ||
| { adapter?: undefined; provider: 'postgresql' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitchellhamilton Is there a better way of saying "one or the other, but not both"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 64ed79d:
|
e7a289a
to
4ccd4c9
Compare
4ccd4c9
to
c1e1cca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to explicitly block this on my review while I check things because I think I will have comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine except for the @deprecated
bit: can you remove the colon(it doesn't make sense and looks weird when shown in editors) and add the @deprecated
comment to both the adapter?: undefined
cases so that the adapter option shows as deprecated in autocomplete (currently in this PR, it doesn't look like this)?
c1e1cca
to
64ed79d
Compare
Now that we only support Prisma the question isn't "which keystone adapter do you want?" as much as "which Prisma provider do you want to use?". This deprecates
db.adapter
, which will be removed in the next release.