Cleanups in the prisma adapter #5319
Conversation
🦋 Changeset detectedLatest commit: 51cfac9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/2F8pcwwREDJAyGWpY5hto8gh7Ppg |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 51cfac9:
|
| Object.values(this.listAdapters).forEach(listAdapter => { | ||
| listAdapter._postConnect({ rels, prisma: this.prisma }); | ||
| }); |
There was a problem hiding this comment.
Could you move this to before the connect(and you might want to rename _postConnect too then)? Since then you can remove the catching and disconnecting stuff below and it's important for the Next-lite stuff that the list APIs can be called synchronously(even though they'll ofc return asynchronously) and moving it to before the connect enables that (in that PR currently, I call postConnect on the adapter to make it work)
timleslie
force-pushed
the
cleanup-prisma-adapter
branch
from
05251c6 to
decc8f0
Compare
timleslie
force-pushed
the
cleanup-prisma-adapter
branch
from
00daa9e to
51cfac9
Compare
This PR cleans up some methods and properties we no longer need, along with some unused code paths. Makes it much easier to follow what happens during the
connect()operation.