Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide next vs 6 #5301

Merged
merged 10 commits into from
Mar 31, 2021
Merged

Guide next vs 6 #5301

merged 10 commits into from
Mar 31, 2021

Conversation

raveling
Copy link
Contributor

  1. Turn’s Jed's Github comment into a guide.
  2. Add link to guide in sidebar

A few resources on the Keystone 5 site will point to this guide soon. PR for that pending

@raveling raveling requested review from timleslie and JedWatson March 30, 2021 21:24
@vercel
Copy link

vercel bot commented Mar 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/94kmB7vHMAGCrcpA1VcoXdoZB22j
✅ Preview: https://keystone-next-docs-git-guide-next-vs-6-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: e2025c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e2025c9:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview March 30, 2021 22:05 Inactive
timleslie
timleslie suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos and the such.

docs-next/components/Navigation.tsx Outdated Show resolved Hide resolved
docs-next/pages/guides/keystone-5-vs-keystone-next.mdx Outdated Show resolved Hide resolved
docs-next/pages/guides/keystone-5-vs-keystone-next.mdx Outdated Show resolved Hide resolved
docs-next/pages/guides/keystone-5-vs-keystone-next.mdx Outdated Show resolved Hide resolved
docs-next/pages/guides/keystone-5-vs-keystone-next.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview March 30, 2021 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 22:17 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 22:36 Inactive
@raveling
Copy link
Contributor Author

raveling commented Mar 30, 2021 •
edited
Loading

@timleslie believe all your changes requests now fulfilled

timleslie
timleslie approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@vercel vercel bot temporarily deployed to Preview March 30, 2021 23:13 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 23:20 Inactive
@raveling raveling merged commit c8744fd into master Mar 31, 2021
@raveling raveling deleted the guide-next-vs-6 branch March 31, 2021 00:11
@keystonejs-release-bot keystonejs-release-bot mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timleslie timleslie timleslie approved these changes

@JedWatson JedWatson Awaiting requested review from JedWatson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raveling @timleslie