Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove knex adapter #5278

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Remove knex adapter #5278

merged 1 commit into from
Mar 30, 2021

Conversation

timleslie
Copy link
Contributor

See #5025

@vercel
Copy link

vercel bot commented Mar 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/62rFjYqxYFn332mobDpEPRYN9KhE
✅ Preview: https://keystone-next-docs-git-remove-knex-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 58999eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview March 30, 2021 04:04 Inactive
@timleslie timleslie changed the title [WIP] Remove knex adapter Remove knex adapter Mar 30, 2021
@timleslie timleslie requested a review from JedWatson March 30, 2021 04:04
JedWatson
JedWatson approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@JedWatson JedWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zed's dead baby, Zed's dead.

packages/fields-auto-increment/README.md
@@ -6,7 +6,7 @@ title: AutoIncrement

# AutoIncrement

An automatically incrementing integer with support for the Knex adapter. It's important to note that this type:
An automatically incrementing integer with support for the Prisma adapter. It's important to note that this type:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not at this point, but eventually, we'll do a sweep and remove all references to "adapters" entirely.

@timleslie timleslie merged commit 5777fc6 into master Mar 30, 2021
@timleslie timleslie deleted the remove-knex branch March 30, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JedWatson JedWatson JedWatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timleslie @JedWatson