Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of getDbSchemaName, getPrismaPath, migrationMode and dropDatabase from tests #5276

Merged
merged 14 commits into from
Mar 30, 2021
Merged

Remove usage of getDbSchemaName, getPrismaPath, migrationMode and dropDatabase from tests #5276

merged 14 commits into from
Mar 30, 2021

Conversation

emmatown
Copy link
Member

This means that we'll be able to rip out all that stuff soon.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 396c5c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@keystone-next/test-utils-legacy Major
@keystone-next/keystone Minor
@keystone-next/api-tests-legacy Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/example-ecommerce Patch
@keystone-next/auth Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/E9k2MU3R8ZgiVsent71yeAUDcFmc
✅ Preview: https://keystone-next-git-remove-usage-of-get-db-schema-name-ge-3f0e9c.vercel.app

@emmatown emmatown mentioned this pull request Mar 30, 2021
Closed
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b265fd9:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview March 30, 2021 02:24 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 396c5c3:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview March 30, 2021 02:36 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 02:44 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 02:51 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 04:33 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 04:50 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 04:54 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 05:15 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 05:26 Inactive
@vercel vercel bot temporarily deployed to Preview March 30, 2021 05:43 Inactive
emmatown
emmatown commented Mar 30, 2021
View reviewed changes
packages/adapter-prisma/src/migrations.ts
dbUrl: string,
schema: string,
schemaPath: string,
shouldDropDatabase = false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I didn't add a changeset for this because there hasn't yet been a release where runPrototypeMigrations was publicly exported.

@emmatown emmatown changed the title Remove usage of getDbSchemaName, getPrismaPath and migrationMode from tests Remove usage of getDbSchemaName, getPrismaPath, migrationMode and dropDatabase from tests Mar 30, 2021
@emmatown emmatown marked this pull request as ready for review March 30, 2021 05:47
@emmatown emmatown requested a review from timleslie March 30, 2021 05:59
This was referenced Mar 30, 2021
Merged
Merged
timleslie
timleslie approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this all checks out 👍

@vercel vercel bot temporarily deployed to Preview March 30, 2021 21:30 Inactive
@emmatown emmatown enabled auto-merge (squash) March 30, 2021 21:30
@emmatown emmatown merged commit 1a4db6c into master Mar 30, 2021
@emmatown emmatown deleted the remove-usage-of-get-db-schema-name-get-prisma-path-and-migration-mode-from-tests branch March 30, 2021 21:36
@keystonejs-release-bot keystonejs-release-bot mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timleslie timleslie timleslie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmatown @timleslie