Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Next image service #5272

Closed
wants to merge 5 commits into from
Closed

[WIP] Next image service #5272

wants to merge 5 commits into from

Conversation

rohan-deshpande
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2021

⚠️ No Changeset found

Latest commit: 99eeed5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/2RBJUrZPDHu9C2xhtYWwXoy4pjrx
✅ Preview: Failed

[Deployment for 99eeed5 failed]

@rohan-deshpande rohan-deshpande marked this pull request as draft March 30, 2021 00:37
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5f5f730:

Sandbox Source
@keystone-next/example-sandbox Configuration

export type GraphqlImageInputType = {
field: {
mode: 'local' | 'cloud';
id: string;
Copy link
Contributor Author

@rohan-deshpande rohan-deshpande Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably only need mode and id for the input type, mode would be optional

filesize: number;
};
};
export type GraphqlImageOutputType = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum ImageObjectFit { FIXED INTRINSIC RESPONSIVE FILL }

ImageOutputType {
	id: ID!
	extension: TEXT!
	src: TEXT
	width: INTEGER
	height: INTEGER
	blurHash: { hash: TEXT, x: INTEGER, y: INTEGER }
	fileSize: INTEGER
	# Mabes add this later?
	transform (
		# This is "whatever the Next image component accepts"
		width: INTEGER
		height: INTEGER
		quality: INTEGER
		objectFit: ObjectFit
	) {
		src: TEXT
		width: INTEGER
		height: INTEGER
	}
}

@vercel vercel bot temporarily deployed to Preview March 31, 2021 03:36 Inactive
@vercel vercel bot temporarily deployed to Preview March 31, 2021 04:05 Inactive
@timleslie
Copy link
Contributor

This PR has been superseded by the #5396 PR 👍

@timleslie timleslie closed this Apr 19, 2021
@timleslie timleslie deleted the next-image-service branch May 5, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants