Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keystone argument from server-side-graphql-client functions #5222

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Mar 24, 2021

We no longer need to support the keystone argument, it should always be used with a context argument.

There's a cursory attempt to update the docs, but these need a complete overhaul/integration into the items API, so not too fussed about having them be completely correct right this minute.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2021

🦋 Changeset detected

Latest commit: c0e0375

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@keystone-next/server-side-graphql-client-legacy Major
@keystone-next/benchmarks-legacy Patch
@keystone-next/example-ecommerce Patch
@keystone-next/keystone Patch
@keystone-next/test-utils-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/DDh85nNXQ8tksQjx3fz7RGNSqNiV
✅ Preview: https://keystone-next-docs-git-remove-keystone-from-ssgc-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0e0375:

Sandbox Source
@keystone-next/example-sandbox Configuration

@timleslie timleslie force-pushed the remove-keystone-from-ssgc branch from a28faf6 to a8fe7bb Compare March 25, 2021 02:55
@vercel vercel bot temporarily deployed to Preview March 25, 2021 02:55 Inactive
@timleslie timleslie force-pushed the remove-keystone-from-ssgc branch from a8fe7bb to 8abc704 Compare March 25, 2021 05:08
@vercel vercel bot temporarily deployed to Preview March 25, 2021 05:08 Inactive
@timleslie timleslie force-pushed the remove-keystone-from-ssgc branch from 8abc704 to 5a2c9ad Compare March 25, 2021 22:44
@vercel vercel bot temporarily deployed to Preview March 25, 2021 22:44 Inactive
@timleslie timleslie force-pushed the remove-keystone-from-ssgc branch from 5a2c9ad to 340f473 Compare March 26, 2021 02:05
@vercel vercel bot temporarily deployed to Preview March 26, 2021 02:05 Inactive
@timleslie timleslie force-pushed the remove-keystone-from-ssgc branch from 340f473 to 7fb4cae Compare March 26, 2021 02:25
@vercel vercel bot temporarily deployed to Preview March 26, 2021 02:26 Inactive
@timleslie timleslie changed the title [POC] Remove keystone argument from server-side-graphql-client functions Remove keystone argument from server-side-graphql-client functions Mar 26, 2021
@timleslie timleslie force-pushed the remove-keystone-from-ssgc branch from 7fb4cae to c0e0375 Compare March 26, 2021 04:00
@vercel vercel bot temporarily deployed to Preview March 26, 2021 04:00 Inactive
@timleslie timleslie requested a review from a team March 26, 2021 04:00
@timleslie timleslie enabled auto-merge (squash) March 26, 2021 04:00
@timleslie timleslie merged commit db6cb59 into master Mar 26, 2021
@timleslie timleslie deleted the remove-keystone-from-ssgc branch March 26, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants