Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy app-nuxt #5024

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Remove legacy app-nuxt #5024

merged 2 commits into from
Mar 8, 2021

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Mar 7, 2021

Remove the legacy Nuxt.js starter.

See #5025

@timleslie timleslie requested a review from JedWatson March 7, 2021 23:16
@vercel
Copy link

vercel bot commented Mar 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/2Edz45zFWCrjaxcfeZxtYwG5v6gX
✅ Preview: https://keystone-next-docs-git-remove-app-nuxt-keystonejs.vercel.app

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you also remove create-keystone-app from this repo otherwise the next time we publish, create-keystone-app will incorrectly point to the packages in this repo again

@timleslie
Copy link
Contributor Author

Make sure you also remove create-keystone-app from this repo otherwise the next time we publish, create-keystone-app will incorrectly point to the packages in this repo again

Yep, PR for that is in the works 👍

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2021

🦋 Changeset detected

Latest commit: b50e161

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
create-keystone-app Major
@keystone-next/website-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview March 8, 2021 00:03 Inactive
@timleslie timleslie merged commit a85c1c5 into master Mar 8, 2021
@timleslie timleslie deleted the remove-app-nuxt branch March 8, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants