Upgrade to latest version of apollo-related packages #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timleslie
force-pushed
the
upgrade-apollo
branch
from
5395270 to
85a174f
Compare
timleslie
force-pushed
the
upgrade-apollo
branch
from
85a174f to
375b20d
Compare
jesstelford
suggested changes
Oct 8, 2018
| test: /\.mjs$/, | ||
| include: /node_modules/, | ||
| type: 'javascript/auto', | ||
| }, |
There was a problem hiding this comment.
Looks like this isn't needed since [email protected], so we could update that package too.
There was a problem hiding this comment.
Yeah, that's the plan, but we currently have some dependencies which haven't been updated to support 14.0 yet. Once all downstream deps are supported I'll take care of that upgrade.
jesstelford
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these packages appear to have any breaking changes for our use case. The important change from our point of view is that the packages support
graphql=14.0.0as a dependency. We want to keep on top of evolvinggraphqllibrary improvements, and14.0has a number of important bugfixes and improvements.