Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter & CRUD tests for Color field #3404

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

singhArmani
Copy link
Contributor

No description provided.

@singhArmani singhArmani requested a review from timleslie August 17, 2020 04:12
@request-info
Copy link

request-info bot commented Aug 17, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2020

🦋 Changeset is good to go

Latest commit: a1a3177

We got this.

This PR includes changesets to release 2 packages
Name Type
@keystonejs/api-tests Patch
@keystonejs/fields-color Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@singhArmani singhArmani changed the title Add filter & CRUD tests for COLOR field Add filter & CRUD tests for Color field Aug 17, 2020
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Color field type supports case-insensitive filtering, so we will need to make sure we have those tests as well.

@singhArmani singhArmani force-pushed the add-filter-crud-tests-color-field branch from 97ce44d to a1a3177 Compare August 17, 2020 05:48
@singhArmani singhArmani merged commit c906858 into master Aug 17, 2020
@singhArmani singhArmani deleted the add-filter-crud-tests-color-field branch August 17, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants