Cleanup test-utils module #3390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue. |
🦋 Changeset is good to goLatest commit: 625573b We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
singhArmani
changed the title
We were using some crud helper functions, for example findById, findOne, and update, inside `_keystoneRunner` function. But now with the addition of ssgc package we don't need them anymore.
singhArmani
force-pushed
the
cleaup-keystone-runner
branch
from
30a679a to
625573b
Compare
singhArmani
changed the title
|
Consolidating this change into #3388 with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using some crud helper functions, for example
findById,findOne,and
update, inside_keystoneRunnerfunction. But now with the additionof ssgc package we don't need them anymore.