Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small docs tweak #3382

Merged
merged 4 commits into from
Aug 12, 2020
Merged

small docs tweak #3382

merged 4 commits into from
Aug 12, 2020

Conversation

Noviny
Copy link
Contributor

@Noviny Noviny commented Aug 12, 2020

This broke when I was spinning some things up and took a little while to debug what the problem was.

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2020

💥 No Changeset

Latest commit: 017f7be

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Noviny Noviny requested a review from MadeByMike August 12, 2020 03:34
}),
})
.then((result) => result.json())
.then((r) => updateData(r));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is updateData and example of how to do something with the result? If so, maybe we should just assign it to something? i.e?

const result = fetch(...)

Copy link
Contributor

@singhArmani singhArmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Noviny : We also need to wrap the body with JSON.stringify for AddUser mutation call.

 // Inside Add User mutation
  body: {
    query: ADD_USER,
    variables: { name: 'Mike' },
  },
})

Copy link
Contributor

@singhArmani singhArmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Noviny Noviny merged commit 5e0d2e0 into master Aug 12, 2020
@Noviny Noviny deleted the noviny/small-docs-tweaks branch August 12, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants