Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fix to navigate when the Label col is hidden in the list page of admin UI. #3366

Closed
wants to merge 2 commits into from

Conversation

singhArmani
Copy link
Contributor

@singhArmani singhArmani commented Aug 10, 2020

In the list page of admin UI, the Label column was used to open up the
detailed view of a single item. Thus, hiding the Label column was preventing the user to navigate
to a detailed view.

To Fix this, we are setting the linkField to the path of the first field
item.

Closes #2166

hide-label

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2020

🦋 Changeset detected

Latest commit: c081a91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystonejs/app-admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@singhArmani singhArmani force-pushed the open-list-item-admin-ui branch from ef50990 to 4627439 Compare August 10, 2020 06:27
In the list page of admin UI, the `Label` column was used to open up the
detailed view of a single item. Thus, hiding the `Label` column was preventing the user to navigate
to detailed view.

To Fix this, we are setting the `linkField` to the path of first field
item.

Closes #2166
@singhArmani singhArmani force-pushed the open-list-item-admin-ui branch from 4627439 to 43b3a78 Compare August 11, 2020 02:29
@stale
Copy link

stale bot commented Dec 9, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Dec 9, 2020
@stale stale bot removed the needs-review label Feb 3, 2021
@vercel
Copy link

vercel bot commented Feb 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/lxf1i2x7p
✅ Preview: https://keystone-next-docs-git-open-list-item-admin-ui.keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview February 3, 2021 05:04 Inactive
@timleslie
Copy link
Contributor

Closing as out of scope for keystone-next.

@timleslie timleslie closed this Mar 1, 2021
@timleslie timleslie deleted the open-list-item-admin-ui branch May 5, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy way to open item without Label column
3 participants