Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace build field types with preconstruct in most field packages #3342

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Aug 5, 2020

This is the start of removing build-field-types, I'm intentionally not touching field-content, fields or datetime-utc to avoid conflicts with the open PRs about them.

@emmatown emmatown requested a review from MadeByMike August 5, 2020 04:53
@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2020

🦋 Changeset is good to go

Latest commit: abe347f

We got this.

This PR includes changesets to release 6 packages
Name Type
@keystonejs/fields-wysiwyg-tinymce Patch
@keystonejs/fields-markdown Patch
@keystonejs/fields-mongoid Patch
@keystonejs/oembed-adapters Patch
@keystonejs/fields-authed-relationship Patch
@keystonejs/fields-auto-increment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmatown emmatown requested a review from timleslie August 5, 2020 05:21
@gautamsi
Copy link
Member

gautamsi commented Aug 5, 2020

I'm intentionally not touching field-content, fields or datetime-utc to avoid conflicts with the open PRs about them.

should this be merged after those PR. I like it, this way contrib fields would not need the build-field-types step or dependency

@emmatown
Copy link
Member Author

emmatown commented Aug 5, 2020

The intention is to remove build-field-types completely. I'm not touching field-content, fields or datetime-utc in this PR just to avoid conflicts with those currently open PRs. Once this PR and those ones are merged, I'll remove build-field-types from those as well.

@emmatown emmatown merged commit 356dd27 into master Aug 6, 2020
@emmatown emmatown deleted the replace-build-field-types-with-preconstruct-in-most-field-packages branch August 6, 2020 00:56
This was referenced Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants