Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename field-content to fields-content #3304

Merged
merged 11 commits into from
Aug 7, 2020
Merged

Conversation

MadeByMike
Copy link
Contributor

Renamed @keystonejs/field-content to @keystonejs/fields-content.

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2020

🦋 Changeset is good to go

Latest commit: e7141de

We got this.

This PR includes changesets to release 4 packages
Name Type
@keystonejs/field-content Major
@keystonejs/fields-content Major
@keystonejs/fields Patch
@keystonejs/cypress-project-basic Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MadeByMike MadeByMike changed the title Rename @keystonejs/field-content to @keystonejs/fields-content Rename field-content to fields-content Jul 28, 2020
@MadeByMike
Copy link
Contributor Author

I made a decision to keep the version number despite the rename. Since there were no functional change to the package I felt this makes sense.

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a final major release of the original package which throws an error pointing to the new package.

@emmatown emmatown requested a review from timleslie August 7, 2020 04:52
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this all looks good 👍

@emmatown emmatown merged commit 149d6fd into master Aug 7, 2020
@emmatown emmatown deleted the rename-field-content branch August 7, 2020 06:04
This was referenced Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants