-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cloudinary, unsplash and oembed out of fields package and oembed-adapters into new fields-oembed package #3280
Conversation
🦋 Changeset is good to goLatest commit: 836079c We got this. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Even though this is a major, can we export some dummy "fields" with the old names that simply |
Yes, 100%. I was hoping to be able to continue to export the fields package with a deprecation warning, but circular references. Adding dummy fields is a next best option. |
Co-authored-by: Tim Leslie <[email protected]>
f1b78f7
to
f4dd988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a documentation mishap.
Aside from that, I'm strongly in favour of also extracting the Location
field since (like these others) it's tightly coupled to an external service provider (Google) -- let's turn that into fields-location-google
(following our fields-content-tinymce
convention, you could have other location fields backed by other services)
We used to have a Location field in keystone 4 that had support for Google but was also useful independently; the Location field in keystone 5 specifically stores a googlePlaceID
field so I don't see it as belonging in the core set.
Might as well include that in this breaking change set.
Also, our Content
field package is currently mis-named; should be fields-content
not field-content
. Given the theme of this PR/release, might be a good time to deprecate the misnamed package and publish the new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me 👍
Lots of files moved around here but not functional changes. I'm trying to consolidate the "core field packages" and isolate them from other field types. I intend to make this distinction clearer in docs in a future PR.
Moved
@keystonejs/fields-cloudinary-image
,@keystonejs/fields-unsplash
and@keystonejs/fields-oembed
out of the core fields package@keystonejs/fields
.