Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pFinally with native code #3278

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Replace pFinally with native code #3278

merged 1 commit into from
Jul 23, 2020

Conversation

timleslie
Copy link
Contributor

No description provided.

@request-info
Copy link

request-info bot commented Jul 23, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2020

🦋 Changeset is good to go

Latest commit: 01eab32

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@singhArmani singhArmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. :)
If there's an exception in the try block, the finally block will execute all the statements, and then throws the exception.

@timleslie timleslie merged commit 5332988 into master Jul 23, 2020
@timleslie timleslie deleted the remove-p-finally branch July 23, 2020 02:53
This was referenced Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants