Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Apply cache hints to mutation resolvers. #3236

Closed
wants to merge 1 commit into from

Conversation

timleslie
Copy link
Contributor

This change passes the info object down into _itemsQuery in mutations to allow cacheHints to be utilised in these cases.

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2020

🦋 Changeset is good to go

Latest commit: 44b404c

We got this.

This PR includes changesets to release 2 packages
Name Type
@keystonejs/fields Minor
@keystonejs/keystone Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@jesstelford jesstelford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

What's the impact of this? My immediate thought was "We shouldn't cache mutation results" - is that now happening? I can't see any functional change here tbh.

@timleslie timleslie changed the title Apply cache hints to mutation resolvers. [WIP] Apply cache hints to mutation resolvers. Jul 7, 2020
@timleslie timleslie force-pushed the pass-info-around branch 2 times, most recently from e6e6066 to f1a9340 Compare July 14, 2020 23:27
@timleslie
Copy link
Contributor Author

After thinking about this some more I'm no longer convinced that this is a good change. Thanks Jess for the call out. Will close this PR without merging.

@timleslie timleslie closed this Aug 3, 2020
@timleslie timleslie deleted the pass-info-around branch November 9, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants