Formatted CRUD provider typedefs, moved to own file (no functional changes) #3066
Conversation
💥 No ChangesetLatest commit: 2e64001 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Vultraz
changed the title
| @@ -1,6 +1,8 @@ | |||
| const { GraphQLJSON } = require('graphql-type-json'); | |||
| const { flatten, objMerge, unique } = require('@keystonejs/utils'); | |||
|
|
|||
| const { _getListCRUDTypes } = require('./listCRUDTypes'); | |||
There was a problem hiding this comment.
This feels like a weird place for a dangling underscore. Is there a convention we're using that I missed? I've seen us use _method to informally denote "private" API on classes, but it feels weird when used as an export/import
There was a problem hiding this comment.
Nope, not a convention, just a random choice on my part. Removed 👍
Used single-line comments where applicable and ran each block through prettier with a
gqlliteral attached. Also moved them to a getter helper in a separate file since they're getting really long.