Enable list header actions hook #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 1332df1 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gautamsi
approved these changes
May 26, 2020
| list: { access }, | ||
| openCreateItemModal, | ||
| } = useList(); | ||
| if (!access.create) return null; |
There was a problem hiding this comment.
We re taking care of access control here instead of List->index
| @@ -70,7 +68,7 @@ export function ListLayout(props) { | |||
| <HeaderInset> | |||
| <FlexGroup align="center" justify="space-between"> | |||
| <PageTitle>{list.plural}</PageTitle> | |||
| {list.access.create ? listHeaderActions ? listHeaderActions() : <CreateItem /> : null} | |||
| {listHeaderActions ? listHeaderActions() : <CreateItem />} | |||
There was a problem hiding this comment.
Do not want to remove all the header items which dev may have created, list create access check is moved to <CreateItem/> which will not render itself if there is no access for create.
we can leave this to hook author to decide whether they need action for create access or not.
There was a problem hiding this comment.
Good call to move it to create item.
MadeByMike
commented
May 27, 2020
This was referenced May 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gautamsi I had a little git slip and I had to revert and re-open this one. We're still looking at moving forward with it. Forgive me for the confusion.