Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dateFrom, dateTo validation to CalendarDay #3002

Merged
merged 27 commits into from
Jun 10, 2020

Conversation

timleslie
Copy link
Contributor

Implements Proposal 1 from #2922

Still very WIP, currently breaks the admin UI. Needs a whole stack of tests to be written.

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2020

🦋 Changeset is good to go

Latest commit: dc24376

We got this.

This PR includes changesets to release 28 packages
Name Type
@keystonejs/api-tests Patch
@keystonejs/demo-project-blog Patch
@keystonejs/demo-project-meetup Patch
@arch-ui/day-picker Patch
@keystonejs/fields Major
@keystonejs/app-admin-ui Patch
@keystonejs/auth-passport Patch
@keystonejs/auth-password Patch
@keystonejs/field-content Patch
@keystonejs/fields-authed-relationship Patch
@keystonejs/fields-auto-increment Patch
@keystonejs/fields-datetime-utc Patch
@keystonejs/fields-markdown Patch
@keystonejs/fields-mongoid Patch
@keystonejs/fields-wysiwyg-tinymce Patch
@keystonejs/keystone Patch
@keystonejs/list-plugins Patch
@keystonejs/demo-custom-fields Patch
@keystonejs/demo-project-todo Patch
@keystonejs/cypress-project-access-control Patch
@keystonejs/cypress-project-basic Patch
@keystonejs/cypress-project-client-validation Patch
@keystonejs/cypress-project-login Patch
@keystonejs/cypress-project-social-login Patch
@keystonejs/benchmarks Patch
@keystonejs/example-projects-nuxt Patch
@keystonejs/example-projects-starter Patch
@keystonejs/example-projects-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timleslie
Copy link
Contributor Author

To complete this task we need to properly implement a limited range on the Filter component.

This is blocked on upgrading to v8 of the react-day-picker library (see #2922).

@timleslie timleslie force-pushed the calendar-day-range-validation branch from 3ffa404 to 3dbd671 Compare May 26, 2020 23:22
@MadeByMike
Copy link
Contributor

MadeByMike commented Jun 6, 2020

@timleslie I'm not sure when you mean by: "To complete this task we need to properly implement a limited range on the Filter component." The input is validated if the range is dateFrom starting last week and you filter for dates before last week you will get 0 results... I think that's just fine. Or I have misunderstood what you mean by range on the Filter component.

@MadeByMike MadeByMike changed the title [WIP] Add dateFrom, dateTo validation to CalendarDay Add dateFrom, dateTo validation to CalendarDay Jun 10, 2020
@MadeByMike MadeByMike force-pushed the calendar-day-range-validation branch from 6a0f8f7 to 5ec5f7d Compare June 10, 2020 07:52
@MadeByMike MadeByMike merged commit b693b2f into master Jun 10, 2020
@MadeByMike MadeByMike deleted the calendar-day-range-validation branch June 10, 2020 23:58
This was referenced Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants