AnimateHeight fixes for calculating the node height #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 3aa1d6e We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timleslie
approved these changes
May 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with reading the height of the
AnimateHeightnode. BeforescrollHeightwas used which by default rounds the height value down to an integer (mentioned here @MDN) which sometimes for certain OS/browser/zoom-level/font combinations could cause the scrollbar to be visible in the filter add/edit popouts if the height of the node was not an integer.Recommended at MDN
getBoundingClientRect().heightwas not providing correct value reliably for the initial state of the node and only offsetHeight did work correctly in my tests for each case.Also provided proper value
nonefor no transition CSS transition property.