Admin UI: explicit list config #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 8dbeddc We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I think this is ok. @timleslie has been looking at some stuff parallel to this so he might want to get eyes on this one as well. |
|
Possibly related: #1039 |
|
Yes, love this, very much in line with the PRs I've got lined up to make all the |
This was referenced May 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client-side
Listobjects were storing a ton of duplicated and unnecessary data.Here's what one of the Admin UI
Listobjects looked like before:Notice how not only was the entire
adminMetaobject duplicated in every list, but theconfigobject was being saved despite beingassigneded to theListobject. This meant that the entire config object was being saved twice, and it also meant completely unnecessary keys likeviewswere being saved too (these are used by the field view loader and aren't needed here).This removes the copy of
adminMeta(it wasn't used anywhere) and theconfigcopy + assignment in favor of explicitly picking out the pieces ofconfigwe want to save. Note this does mean the raw field config is no longer accessible atlist.config.fields, but it's still available via the field controller inlist.fields.Lot cleaner!