Admin UI: Improvements to Update workflow #2871
Conversation
🦋 Changeset is good to goLatest commit: 12ddf55 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -383,7 +383,7 @@ const ActionItems = ({ mouseIsOverNav }) => { | |||
| ...(ENABLE_DEV_FEATURES | |||
| ? [ | |||
| { | |||
| label: 'GraphiQL Playground', | |||
| label: 'GraphQL Playground', | |||
There was a problem hiding this comment.
Unrelated, I just learned that GraphiQL =/= GraphQL Playground.
Vultraz
changed the title
| const { onDeleteMany, onUpdateMany, selectedItems } = props; | ||
| const [deleteModalIsVisible, setDeleteModal] = useState(false); | ||
| const [updateModalIsVisible, setUpdateModal] = useState(false); | ||
| const SelectedCount = styled.div` |
There was a problem hiding this comment.
Why did we change to template functions here? We use object notation throughout most of the codebase. I'd rather be consistent.
There was a problem hiding this comment.
There's no consistent usage of styled object notation vs template literals. Lot of both. I've been gradually switching to the latter as I've come across it. Haven't touched the function-based ones since I only yesterday realized that they can return a template literal too 😬
|
I still like the idea of keeping the I'm inclined to move forward with this for now |
UpdateManyModalto a functional component. DroppedUpdateManyModalWithMutationin the process.ListManagea bit