Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session cookie sameSite option #2861

Merged
merged 4 commits into from
Apr 30, 2020
Merged

Session cookie sameSite option #2861

merged 4 commits into from
Apr 30, 2020

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Apr 29, 2020

This PR brings in the changes from #2602 with minor documentation tweaks. All credit goes to @ropaolle 🎉

Fixes #2551

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2020

🦋 Changeset is good to go

Latest commit: 10eb10c

We got this.

This PR includes changesets to release 24 packages
Name Type
@keystonejs/keystone Major
@keystonejs/session Major
@keystonejs/adapter-knex Patch
@keystonejs/adapter-mongoose Patch
@keystonejs/test-utils Patch
@keystonejs/demo-project-blog Patch
@keystonejs/demo-custom-fields Patch
@keystonejs/demo-project-meetup Patch
@keystonejs/demo-project-todo Patch
@keystonejs/cypress-project-access-control Patch
@keystonejs/cypress-project-basic Patch
@keystonejs/cypress-project-client-validation Patch
@keystonejs/cypress-project-login Patch
@keystonejs/cypress-project-social-login Patch
@keystonejs/benchmarks Patch
@keystonejs/example-projects-blank Patch
@keystonejs/example-projects-nuxt Patch
@keystonejs/example-projects-starter Patch
@keystonejs/example-projects-todo Patch
@keystonejs/app-admin-ui Patch
@keystonejs/app-graphql-playground Patch
@keystonejs/app-graphql Patch
@keystonejs/auth-passport Patch
@keystonejs/auth-password Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@molomby molomby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@MadeByMike
Copy link
Contributor

I like it

@timleslie timleslie merged commit da1359d into master Apr 30, 2020
@timleslie timleslie deleted the cookie-same-site branch April 30, 2020 22:55
This was referenced Apr 30, 2020
@molomby molomby mentioned this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie sameSite attribute
5 participants