Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin UI: Converted ResizeHandler and ScrollQuery components to custom hooks #2801

Merged
merged 6 commits into from
May 4, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Apr 22, 2020

Pulled the ResizeHandler change out of #2427 and further developed it into a custom hook. No whitespace diff: https://github.com/keystonejs/keystone/pull/2801/files?diff=unified&w=1

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2020

🦋 Changeset is good to go

Latest commit: 6313b60

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/app-admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Vultraz Vultraz changed the title Converted ResizeHandler component to a custom hook Admin UI: Converted ResizeHandler component to a custom hook Apr 22, 2020
@Vultraz Vultraz changed the title Admin UI: Converted ResizeHandler component to a custom hook Admin UI: Converted ResizeHandler and ScrollQuery components to custom hooks May 2, 2020
@Vultraz
Copy link
Contributor Author

Vultraz commented May 2, 2020

Converted ScrollQuery to a custom hook too.

@MadeByMike MadeByMike merged commit d639624 into keystonejs:master May 4, 2020
@github-actions github-actions bot mentioned this pull request May 4, 2020
@Vultraz Vultraz deleted the admin-ui-resize-handler-hook branch May 4, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants