Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Service - Minor refinements #2558

Conversation

irwin-r
Copy link

@irwin-r irwin-r commented Mar 20, 2020

No description provided.

@request-info
Copy link

request-info bot commented Mar 20, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2020

💥 No Changeset

Latest commit: bf449b7

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@JedWatson JedWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @irwin-r thanks for the updates, most of them look good, but there's one bug introduced (I think, haven't tested this branch locally)

Would you mind taking a look at that and we can get this merged?

packages/images/src/service.js Outdated Show resolved Hide resolved
@irwin-r irwin-r force-pushed the image-service-minor-refinements branch from a202ac1 to bf449b7 Compare March 21, 2020 02:12
@stale
Copy link

stale bot commented Jul 19, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Jul 19, 2020
@stale stale bot removed the needs-review label Apr 8, 2021
@bladey
Copy link
Contributor

bladey commented Apr 8, 2021

Thanks for this PR @irwin-r.

Keystone 5 has officially moved into active maintenance mode as we push towards the next major new version Keystone Next, you can find out more information about this transition here.

In an effort to sustain the project going forward, we're cleaning up and closing old PRs such as this one.

However, you are welcome to create a PR under the Keystone 5 repository.

Please let me know if you have any questions.

@bladey bladey closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants