-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show read only field by access in admin ui #2258
Show read only field by access in admin ui #2258
Conversation
🦋 Changeset is good to goLatest commit: 9a9af9a We got this. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c492aed
to
07ae6a3
Compare
691e965
to
bb23890
Compare
e7d361d
to
c466706
Compare
This branch needs more ❤️. |
unless there is any comment from maintainers I can not make any changes. already tried fixing things earlier. I am using this branch in my projects already |
0ff09cc
to
3d27f62
Compare
@LiamAttClarke I have fixed the conflict once more and tried to resolve failing test one last time. |
3d27f62
to
a661040
Compare
@gautamsi (sorry for the OT) |
they are small business companies and did not need a high performance production build so I deployed the whole project. they needed it for internal management of some processes. I had another PR long ago which gives you a I create a repo for my project and deploy the whole keystone repo including my projects folder there. |
Co-authored-by: Jess Telford <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking good, just a few small changes to get it over the line:
- Slight tweaks to the language in the docs/changeset
- One bug to fix in the
Checkbox
field - One functional change in the
create
modal, to completely exclude read only fields, since they have no values to display and so just clutter up the interface at that point.
Co-authored-by: Tim Leslie <[email protected]>
Co-authored-by: Tim Leslie <[email protected]>
I've done this in a way that I think ensure that the hooks for readonly fields will still be triggered... did I get that right?
Update CreateItemModal.js
Co-authored-by: Tim Leslie <[email protected]>
@timleslie I think all feedback is now addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
finally, thanks all. |
Huzzah, congrats! 🎉 |
This renders readonly fields in admin-ui Item Detail/Edit page, does not affect CreateItem modal as any readonly fields do not need to be shown on create as they have no content anyways (mostly).
earlier those details are hidden and you have no ways to see the field where you have read access but no write access.
this renders them as disabled
also added
isReadOnly
option in field's admin config, this one is assumed in some places but the actual implementation was missingthis is how basic test project looks like when all the fields are set to
isReadOnly: true
user item:
post item:
originally if user did not have access (instead of Read Only), all of this would be removed.
this is useful in where you don't want anyone to update the content of some field (access or read only) but still render the content. simple example would be when we use
atTracking/byTracking
plugin, those contents are only visible when you select them in ListTable.example: