Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.isDisabled: true is ignored #8732

Closed
molomby opened this issue Aug 2, 2023 · 0 comments
Closed

ui.isDisabled: true is ignored #8732

molomby opened this issue Aug 2, 2023 · 0 comments
Labels
🐛 bug Unresolved bug

Comments

@molomby
Copy link
Member

molomby commented Aug 2, 2023

According to the docs, I can set ui.isDisabled: true to disable the Admin UI:

isDisabled (default: false): If isDisabled is set to true then the Admin UI will be completely disabled.

But when keystone start us run, the CLI code passes { ui: true, ... } in the second arg, here, which overrides the configured isDisabled value here.

Related to #8046?

Reproduction

  • Create a project
  • Set ui: { isDisabled: true }
  • keystone build
  • keystone start
  • Get error:
$ keystone start
✨ Starting Keystone
✨ Connecting to the database
✨ Creating server
✅ GraphQL API ready
✨ Preparing Admin UI Next.js app
Error: Could not find a production build in the '/my-keystone-app/.keystone/admin/.next' directory. Try building your app with 'next build' before starting the production server. https://nextjs.org/docs/messages/production-start-no-build-id
    at NextNodeServer.getBuildId (/my-keystone-app/node_modules/next/dist/server/next-server.js:345:23)
    at new Server (/my-keystone-app/node_modules/next/dist/server/base-server.js:151:29)
    at new NextNodeServer (/my-keystone-app/node_modules/next/dist/server/next-server.js:172:9)
    at NextServer.createServer (/my-keystone-app/node_modules/next/dist/server/next.js:179:24)
    at async /my-keystone-app/node_modules/next/dist/server/next.js:200:31
    at async NextServer.prepare (/my-keystone-app/node_modules/next/dist/server/next.js:160:24)
    at async start (/my-keystone-app/node_modules/@keystone-6/core/scripts/cli/dist/keystone-6-core-scripts-cli.cjs.dev.js:1277:5)

Expected

App should start without the Admin UI.

molomby added a commit that referenced this issue Aug 2, 2023
@dcousens dcousens closed this as completed Aug 2, 2023
@dcousens dcousens added the 🐛 bug Unresolved bug label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unresolved bug
Projects
None yet
Development

No branches or pull requests

2 participants