-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize the concept of "servers" (including the Admin) #1150
Comments
jesstelford
pushed a commit
that referenced
this issue
May 16, 2019
jesstelford
pushed a commit
that referenced
this issue
May 16, 2019
jesstelford
pushed a commit
that referenced
this issue
May 16, 2019
jesstelford
pushed a commit
that referenced
this issue
May 16, 2019
jesstelford
pushed a commit
that referenced
this issue
May 17, 2019
jesstelford
pushed a commit
that referenced
this issue
May 20, 2019
jesstelford
pushed a commit
that referenced
this issue
May 20, 2019
jesstelford
pushed a commit
that referenced
this issue
May 20, 2019
jesstelford
pushed a commit
that referenced
this issue
May 20, 2019
jesstelford
pushed a commit
that referenced
this issue
May 20, 2019
jesstelford
pushed a commit
that referenced
this issue
May 20, 2019
* Move admin UI session middleware registration to admin UI internals * Specify custom servers from within the index.js file Closes #960 Refs #1150 * Merge core & keystone packages to make testing easier * Rename 'servers' to 'apps' * Pass keystone instance to AdminUIMeta generator * Custom servers import the keystone instance directly + prepare is an instance method. Also must explicitly declare the GraphQL API instance as an app * Static file app uses { path, src } for API * Named exports for Apps * Rename disableDefaultRoute option to enableDefaultRoute and default to false * Linting & test fixes
Done in #1109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From https://github.com/keystonejs/keystone-5/pull/960#issuecomment-480101846
Goals
1️⃣ Maintain separation between
index.js
&server.js
("Custom Server").2️⃣ You'd setup UI's/Servers in one or the other of
index.js
orserver.js
. Ie; If you have a Custom Server, you should not exportservers:
fromindex.js
(technically you could, it just wouldn't do anything).3️⃣ Reframe the Admin UI from being "something special" to "Just another frontend"
4️⃣ All the UI's / Servers follow a common API (very similar to how we already do fields!)
5️⃣ The custom server is still un-opinionated, and you can really do whatever you want there.
6️⃣ All the servers need a
build
step for preparing for a production deploy7️⃣ Without a Custom Server, the CLI would become just
index.servers.forEach(server => app.use(server.middleware()))
Example
index.js
server.js
@keystone-alpha/server-next
@keystone-alpha/server-static
@keystone-alpha/server-create-react-app
The text was updated successfully, but these errors were encountered: