Using multer options for CRUD operations on admin UI fields #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to save texts fields in the admin UI that exceed the default multer limit of 1mb.
Description of changes
To set custom multer options it is currently necessary to set 'handle uploads' to true and define an object with the key 'multer options'.
'multer options': { dest: tmpdir(), limits: { fieldSize: 25 * 1024 * 1024 //25 mb } }, 'handle uploads': true,These options are currently being applied during the setup of body-parser (server/bindBodyParser.js).
This pull request would also apply the options in the dynamic router (admin/server/app/createDynamicRouter.js) where multer is being used to process updates to fields in the admin UI.
Related issues (if any)
#4843
Testing
(!) WIP currently eslint fails with 291 problems (291 errors, 0 warnings) on my MacOS setup.
npm run test-allran successfully.