Removing deprecated package "letsencrypt-express" and replacing it with "greenlock-express" #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-acme-core trickling down to request hawk then cryptile which exposes the vulnerability, upgrading to the new module greenlock removes this dependancy trail
JedWatson
approved these changes
Apr 5, 2019
|
Thanks @akopcz2 I resolved the conflict here and updated to the current version. Also actually removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecated package "letsencrypt-express" and replacing it with "greenlock-express". this removes the vulnerable dependency trail of letsencrypt-express requiring
"le-acme-core" trickling down to "request" requiring "hawk" which requires the vulnerable package "cryptile" which exposes the vulnerability CVE-2018-1000620
Upgrading to the new module "greenlock-express" removes this entire dependency trail
Description of changes
Package.json
Removed deprecated letsencrypt-express dependancy and replace it greenlock-express.
Inside /server/initLetsEncrypt.js
Replaced require statement to require "greenlock-express" instead of deprecated letsencrypt-express