Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship Values not clearing via admin API #4755

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

millsy
Copy link

@millsy millsy commented Jul 31, 2018

When removing a relationship value in the admin API, the value wasn't clearing because there was a check forvalue === undefined which resulted in the update ignoring that change.

Tested and confirmed to be working

@stennie stennie added the bug label Sep 25, 2018
Copy link
Contributor

@autoboxer autoboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@millsy, I made a small suggestion to clean up your pull request, but will get this merged soon once you're able to make the update.

fields/types/relationship/RelationshipType.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants