Merge master into Nested lists #4655
Conversation
Update uglify-js to version 2.8.13 🚀
- nav improvements - styling docs
change import to use importer
Implemented timezone fix for fields that use the 'Date' type
Fix for known security vulnerability in marked 0.3.6 dependency
Fix: model with required field that defaults to 0 can't be saved
Fix custom nav links
* Update `cloudinaryimage` to respect autocleanup * Fixes autocleanup for cloudinaryimages * Remove completed TODOs
Add field type Code (http://keystonejs.com/docs/database/#fieldtypes-code)
(feat) implements image thumbnails for the File type
- knox-s3 is a fork of knox with one difference: a mime 1.x dependency that avoids breaking changes in mime 2.x - this matches the `keystonejs/knox` repo, but is published to npm - allows keystone to be installed without git e.g. in a node:slim Docker container close #4573
For more info, see: https://nvd.nist.gov/vuln/detail/CVE-2017-18214 This is currently triggering github security alerts on all projects using keystone 4.x
Fixes scroll for modals in the Admin UI
* Update website to work
|
@michael-silva Thanks for your interest in contributing to Keystone! We're currently focused on identifying and addressing blocking issues for a Keystone 4.0.0 GA release and this particular feature is one with a lot of history. Based on discussion with @JedWatson I gather there are some fundamental architectural challenges which led to this feature being much harder to correctly implement than anticipated. There is still a fair bit of development and testing effort required and it also seems like there may be a lack of clarity/agreement on the scope of what the "nested list" feature is intended to do. Before diving into code changes I think a better starting set of tasks would be to summarise the current state of the related branch(es)/forks, clarify the scope of the feature, and get some feedback on the remaining challenges from Keystone contributors. This is not a blocking feature for the Keystone 4.0.0 release, so it would be best to pause any effort until we have the bandwidth to address properly. If you want to most effectively contribute to Keystone 4 at this stage, assistance with tasks for the 4.0.0 release would definitely be welcome. An updated Contributing Guide is in the works to help onboard new contributors, but the first step would be joining discussion on the KeystoneJS Community Slack. Regards, |
|
@michael-silva I'm going to close this PR so we can properly evaluate nested lists after Keystone 4.0.0 GA. That doesn't preclude you continuing work in your own fork, but as noted in my earlier comment the scope & challenges of this feature are not clear. It is also unclear which branch/fork has the most current changes, but I suspect it is not Regards, |
I would like to work at this feature, so I think this is the first step.