Restore/repair S3 image uploading in tinymce #4594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
To get the S3 image uploading in HTML text entry working again:
uploadimage
tinymce pluginplugin.min.js
copied from @kraenhansen's work in NationalMuseumofDenmark/collections-online@85c7c28, along with language filesplugin.min.js
has been customized to work with Keystone.q("csrf-token")
has been replaced withKeystone.csrf.header['x-csrf-token']
in order to successfully grab the csrf tokenS3FileType.js
to functionRelated issues
keystonejs/keystone#4388, keystonejs/keystone#3529
Testing
There are like 54 failing tests and none of them have anything to do with this, but just including that per the form.