#4480 - Added listening for ctrl+s in EditForm #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zacharysang Apologies for the delayed feedback. Can you confirm which browser(s) you tested this with? This appears to be work with Firefox 61.0 (macOS) but doesn't override the default key event when I tested in Chrome 67.0.3396.87 (macOS). Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added a listener for keypress event on the EditForm component. This listener checks that ctrl+s keys are pressed and if so, triggers the updateItem (save) function.
Related issues (if any)
#4480
Testing
npm run test-allran successfully.