Fixed overwrite in Adapters.FS

[Aldlevine]

Description of changes

This change solves an issue that would prevent keystone.Storage.Adapters.FS from overwriting a file when whenExists == 'overwrite'. For example, previously the below configuration would return an EEXIST error when the file path being written already exists.

const storage = new keystone.Storage({
  adapter: keystone.Storage.Adapters.FS,
  fs: {
    path: path,
    publicPath: path,
    whenExists: 'overwrite',
    generateFilename: keystone.Storage.contentHashFilename,
  }
});

This issue is resolved by enabling the clobber option in fs-extra.move.

Note: If updating to later versions of fs-extra the clobber option must be changed to overwrite.

Related issues (if any)

#4245 (See comment 2)

Testing

• Please confirm npm run test-all ran successfully.

Same tests pass/fail as do in current master branch.

[JedWatson]

This looks good @Aldlevine, thanks!

[Pyav123]

Hello,
Anybody still facing this issue? This solution is not working for me.
There two things in this.

@Aldlevine
First, when I installed keystone([email protected] ) I didn't get the fix made keystonejs/keystone@f262c67 for node_modules\keystone\lib\storage\adapters\fs\index.js .

So, Second I tried to copy and paste the adapter fix code (node_modules\keystone\lib\storage\adapters\fs\index.js ) into my node modules but still it isn't working. Can anyone suggest me on this ? I want to upload and overwrite files such as html,css,js etc in CMS.