Fix attempt for issue #3979: blank page login, qs bug from mapped custom domain #4432
+33
−6,023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages.js generates a Uncaught SyntaxError: Unexpected string when minified, and fails to load the admin interface. After some digging I found that uglifyjs compresses the typeof checks into the following format "undefined"==typeof x which triggers a syntax error after passing through another minification process when deployed. A way to prevent this from happening is to allow semicolons in the uglifyjs command. Also needed to add the 'aphrodite/no-important' to the required packages for the Admin UI.
|
@t100n So glad someone got to the bottom of this rabbit hole. We haven't encountered the issue, so I can't validate that this fixes it, but I take that it fixed the issue for you? Also, why was adding aphrodite relevant to resolve this? |
|
@Noviny indeed this was the solution for my problem. I was forced to add 'aphrodite/no-important' because it was triggering a missing module while loading the admin UI, during my testing of the new packages.js file. So it was just to make it work. |
|
@t100n Thanks for providing this fix. |
stennie
changed the title
|
@t100n where will i find all these "semicolons = true".... I should tamper with the npm package(keystone) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set semicolons=true in the build command that is passed to uglifyjs.
Added 'aphrodite/no-important' to the required packages in admin/client/packages.js.
Issue #3979 :
admin/public/js/packages.js generates a Uncaught SyntaxError: Unexpected string when minified, and fails to load the admin interface.
After some digging I found that uglifyjs compresses the typeof checks into the following format "undefined"==typeof x which triggers a syntax error after passing through another minification process when deployed.