Update TinyMCE to version 4.6.5 #4422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added knox-s3 and updated references.
|
I'm going to close this in favour of updating to the latest TinyMCE (currently 4.7.13), tracked as #4699. |
|
Super, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updated TinyMCE to version 4.6.5.
Related issues (if any)
Fixes error when selecting an element, such as an image and then clicking the link button in the toolbar, resulting in:
Uncaught DOMException: Failed to execute 'setBaseAndExtent' on 'Selection': There is no child at offset 1.
See: tinymce/tinymce#3611 for more information.
Testing
npm run test-allran successfully.Tests are failing for me due to ESLint module errors. I have installed all of the modules referenced, but tests are still failing on: Error: Cannot find module 'eslint-config-keystone'