Update tests for custom admin path

[IgorKhromov]

Now with 'admin path' options, list loading is infinity and broken, because of hardcoded keystone path in query params sagas.

[tmvanetten]

@IgorKhromov. I pulled in your changes and it does not resolve the issue. Looks like there is still something hardcoded somewhere.

[tmvanetten]

Anyone else have insight on the custom admin path not working in beta-5?

[tmvanetten]

Any movement planned for this one?

[tmvanetten]

@Noviny this one is solved in #4586

[crazyx13th]

I think the small problem with your fix is:

• i set keystone.set('admin path', 'test123');
• inside queryParamsSagas.js > * evalQueryParams() I insert
  console.log('Keystone.adminPath:', Keystone.adminPath);

output: /test123

your script-line:

if (pathname !== `/${Keystone.adminPath}/${currentList.id}`) return;

is wrong, because result has "double-slash"

if (pathname !== `//test123/${currentList.id}`) return;

thx!

solution:

(sould work,... I hope)
/admin/client/App/sagas/queryParamsSagas.jsqueryParamsSagas.js, line 71:

if (pathname !== `${Keystone.adminPath}/${currentList.id}`) return;

(not testet)
/admin/client/App/sagas/test/queryParamsSagas.test.js, line 69:

const pathname = `${Keystone.adminPath}/${currentList.id}`;

[crazyx13th]

ohh, now I got it, sorry, but there isn't a release with this fix, thx!

[dev-dem]

This branch has conflicts that must be resolved

Could anyone fix this conflicts files to have pulled this fix ? pushing node_modules is not recommended =/
Thanks!.

[stennie]

Thanks for flagging @dev-dem. It looks like the code fix was already merged to master in #4586, but tests were not updated as per this PR. Changes will be included in the next Keystone release.

Regards,
Stennie

[dev-dem]

@stennie, thank you for the fast answer !

Best!
Dem.-

[stennie]

FYI, a code fix for this issue is included in Keystone 4.0.0-rc.0 which is now available via npm. Release notes: https://github.com/keystonejs/keystone/releases/tag/v4.0.0-rc.0.

This PR is still open pending review of the changes for tests.

Regards,
Stennie