Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Admin UI: Switching page to referenced model #4367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unsigned6
Copy link

Fix issue with Admin UI: Switching page to referenced model (temporary) breaks app.

Issue was happening because to loadValue was passing object, and because of this was failing in ternary operator :

values = Array.isArray(values) ? values : values.split(',');

changed this ti check if really string or array and only then use split if this param is type of string. In other case set empty array.

Tried to use this instead of npm package: for me it resolves issue described in keystonejs/keystone#3696

But for me occurs another one when use repository from my github : occurs warnings in browser console of admin page

[Violation] Forced reflow while executing JavaScript took 35ms

I think this because in my repository is missing bundles which are there when install from npm and are placed in keystone/admin/js folder .
Could anybody please prepare me this bundles?

@unsigned6
Copy link
Author

was doing this from version 4.0.0-beta.4 release

@stennie stennie added the bug label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants