Fix error building FieldTypes on Linux

[AurelioDeRosa]

Description of changes

Set the first letter of the field to uppercase

Related issues (if any)

Fixes #3754

Testing

• Please confirm npm run test-all ran successfully.

[jstockwin]

Would it be worth instead using the keyToLabel function from keystone-utils here? Or are the two operations not quite the same? Seems to me that we should use the utils functions where possible, as they should be pretty good at handling all possible cases correctly.

https://github.com/keystonejs/keystone-utils/blob/master/lib/index.js#L636

[AurelioDeRosa]

As far as I can tell, only the first letter needs to be uppercased, but you surely know the app better than I do.

[jstockwin]

Haha, don't be too sure of that. You're probably right.

[jstockwin]

We have to end up with camel-cased file names right, e.g. "CloudinaryImage", so I guess it depends what the input is. I'm sure your way works fine, but I think using the utils function should too.

I guess it doesn't really matter that much anyway though, so maybe just leave it.

[AurelioDeRosa]

Cool then :)

[JedWatson]

We should actually be using the properName property on the node implementation for the Field Type. cc/ @bassjacob

[AurelioDeRosa]

Let me know how to update the PR to have it landed.

[jstockwin]

Does fieldTypes[type].properName work?

[iamstiil]

I don't think fieldTypes[type].properName would work.

My fieldTypes looks like this:

{
  boolean: 'Boolean',
  number: 'Number',
  text: 'Text',
  select: 'Select',
  file: 'File',
  color: 'Color',
  grid: 'Grid',
  datetime: 'Datetime',
  relationship: 'Relationship',
  textarea: 'Textarea',
  name: 'Name',
  email: 'Email',
  password: 'Password'
}

Grid is a Custom-Fieldtype, so it can be ignored.

Edit:
Seems like _.upperFirst does not fix the issue.

My errors look like Cannot find module 'types/password/PasswordFilter' from '/var/www/server/node_modules/keystone/admin/client'.

Keystone tries loading from '/var/www/server/node_modules/keystone/admin/client' instead from '/var/www/server/node_modules/keystone/fields'

Edit 2:
My Repo was not up to date. It fixed itself ^^