[Nested Lists] ListType: reset list when no value is submitted, cast objects with nu… #3776
Conversation
…meric keys to array
| // Reset the value when null or an empty string is provided | ||
| if (values === null || values === '') { | ||
| // Reset the value when no value or null or an empty string is provided | ||
| if (values === undefined || values === null || values === '') { |
There was a problem hiding this comment.
This is a definite change in semantics, I think it would be better to leave the undefined case as-is…
There was a problem hiding this comment.
Sorry, I was cheating here to fix two bugs at once.
With the undefined case as it is there is no way to empty out the list. The last item will never be deleted because an empty list won't be submitted at all. TextArray, DateArray, and NumberArray all treat undefined the way I've done here.
| if (!Array.isArray(values)) { | ||
| values = [values]; | ||
| if (typeof values === 'object' && values[0] !== undefined) { |
There was a problem hiding this comment.
I think you should use hasOwnProperty in this instance, although for this particular use case, I suppose array values should always be at least null? Not sure.
There was a problem hiding this comment.
Good catch, hasOwnProperty is probably more correct. Thanks!
…0' as own property
JedWatson
changed the title
Description of changes
multerthat causes submitted arrays of 22 items or more to be parsed as objects instead of arrays.Related issues (if any)
Testing
npm run test-allran successfully.…meric keys to array