Leverage the latest PO api refactoring.

[webteckie]

Description of changes

This change set leverages the latest e2e PO api refactoring.

Related issues (if any)

N/A

Testing

• Please confirm npm run test-all ran successfully.

cc: @jstockwin (please review, if all ok, please bump e2e dependency and ask for merge)

[jstockwin]

I'm still a little unsure about the clickDeleteItemIcon function. The delete icon is always in column 1 is it not?

[webteckie]

@jstockwin not sure and why make that assumption? The list can be configured with options that cause other icons to show to the left of the items. Not sure why you think this should be a special case.

[jstockwin]

@webteckie One comment, which is to do with the other repo really, so happy to merge this anyway.

Could you maybe also update the keystone-nightwatch-e2e version number in package.json, so that when I publish your PR from the other repo we can re-run the above tests and check travis passes?

[jstockwin]

Alright, then just leave it. I think I've just never seen it not in the
first row.

On Tue, 4 Oct 2016, 11:45 Carlos Colon, [email protected] wrote:

@webteckie commented on this pull request.

In test/e2e/adminUI/tests/group002Home/uxTestHomeView.js
keystonejs/keystone#3561:

@@ -102,11 +102,11 @@ module.exports = {
.click('@nameListSubmenu')
.waitForListScreen();

• browser.adminUIListScreen
  

•     .click('@singleItemDeleteIcon');
  

• browser.adminUIListScreen.clickDeleteItemIcon([
  

•     { row: 1, column: 1 }
  

@jstockwin https://github.com/jstockwin not sure and why make that
assumption? The list can be configured with options that cause other icons
to show to the left of the items. Not sure why you think this should be a
special case.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
keystonejs/keystone#3561, or mute the thread
https://github.com/notifications/unsubscribe-auth/AH2LryHt_8KW0fDLAOzxxfI3k_eZwCWXks5qwi5SgaJpZM4KNOn5
.