Replace double slashes with single ones when mounting keystone on existing express app
#2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems very reasonable to me. We'll need to port that change to 0.4 too, would you mind submitting a PR against the master branch too with the same change? |
|
As far as I can see the |
|
@mxstbr I think this is handled differently in 0.4... let's set up a test case for it in the test project, and merge this in now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When using the
mountfunction as described in the wiki, one runs into issues when mounting on root path '/' and trying to open keystone-related URLs as e.g. the admin area. Express doesn't correctly redirect, leading to 404 errors.This PR fixes this issue by replacing double slashes with single slashes after the current url concatenation via
mountPath + req.url.Related issues (if any)
Testing
npm run testran successfully.